feat: Poseidon2-based Sponge function #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxiong
changed the title
|
I have no clue about the CI error, firstly we didn't use getrandom 0.2.15, (in my local cargo.lock, we only depends on 0.2.12); secondly, that error shouldn't come from any of my changes. We can safely review the code and ignore this error for now. (I will figure it out later) |
mrain
reviewed
Dec 13, 2024
| @@ -24,7 +24,7 @@ displaydoc = { workspace = true } | |||
| hashbrown = { workspace = true } | |||
| hex = "0.4.3" | |||
| itertools = { workspace = true, features = ["use_alloc"] } | |||
| jf-poseidon2 = { path = "../poseidon2" } | |||
| jf-poseidon2 = { version = "0.1.0", git = "https://github.com/EspressoSystems/jellyfish" } | |||
There was a problem hiding this comment.
should we also have a version number bump for jf-merkle-tree after CRHF is done?
There was a problem hiding this comment.
yes, I'll introduce the CRHF in the next PR, then another one after that to bump jf-merkle-tree
mrain
approved these changes
Dec 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #709 (Item 1 and 3)
This PR:
nimue'strait SpongeDuplexSpongefor all the parameters we have (including various rate, given the same state size)Caveats:
nimue-v0.1.0which is the only published version, has compilation error, which I have reported upstream and help submit a PR to fix it.I will push for a release tag of
0.1.1from the upstream and later repin ournimuedependency, for now, I'm pointing to my own fork/branchBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
CHANGELOG.mdof touched crates.Files changedin the GitHub PR explorer